Actions
Bug #65808
closedTest failure: test_idem_unaffected_root_squash (tasks.cephfs.test_admin.TestFsAuthorizeUpdate)
Status:
Resolved
Priority:
High
Assignee:
Category:
Correctness/Safety
Target version:
% Done:
0%
Source:
Q/A
Backport:
squid
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
qa-suite
Labels (FS):
qa, qa-failure
Pull request ID:
Tags (freeform):
backport_processed
Merge Commit:
Fixed In:
v19.3.0-4639-gf070510eb3
Released In:
v20.2.0~2116
Upkeep Timestamp:
2025-11-01T01:26:50+00:00
Description
2024-05-06T06:20:37.407 INFO:tasks.cephfs_test_runner:====================================================================== 2024-05-06T06:20:37.407 INFO:tasks.cephfs_test_runner:FAIL: test_idem_unaffected_root_squash (tasks.cephfs.test_admin.TestFsAuthorizeUpdate) 2024-05-06T06:20:37.407 INFO:tasks.cephfs_test_runner:Test that "root_squash" is not deleted from MDS caps when user runs 2024-05-06T06:20:37.408 INFO:tasks.cephfs_test_runner:---------------------------------------------------------------------- 2024-05-06T06:20:37.408 INFO:tasks.cephfs_test_runner:Traceback (most recent call last): 2024-05-06T06:20:37.408 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_ceph-c_25eb20a061356442d4a1c711818ce2e5848c382d/qa/tasks/cephfs/test_admin.py", line 1868, in test_idem_unaffected_root_squash 2024-05-06T06:20:37.408 INFO:tasks.cephfs_test_runner: self.assertIn(cap, keyring) 2024-05-06T06:20:37.408 INFO:tasks.cephfs_test_runner:AssertionError: 'allow rw fsname=cephfs path=dir1 root_squash' not found in '[client.testuser]\n\tkey = AQCsdjhmArDuHBAA9INQFVx9a6MqjzgFnVeZxA==\n\tcaps mds = "allow rw fsname=cephfs path=dir1"\n\tcaps mon = "allow r fsname=cephfs"\n\tcaps osd = "allow rw tag cephfs data=cephfs"\n'
Same failure from a different run
2024-04-24T11:21:40.241 INFO:tasks.cephfs_test_runner:====================================================================== 2024-04-24T11:21:40.241 INFO:tasks.cephfs_test_runner:FAIL: test_idem_unaffected_root_squash (tasks.cephfs.test_admin.TestFsAuthorizeUpdate) 2024-04-24T11:21:40.241 INFO:tasks.cephfs_test_runner:Test that "root_squash" is not deleted from MDS caps when user runs 2024-04-24T11:21:40.241 INFO:tasks.cephfs_test_runner:---------------------------------------------------------------------- 2024-04-24T11:21:40.241 INFO:tasks.cephfs_test_runner:Traceback (most recent call last): 2024-04-24T11:21:40.241 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/github.com_rishabh-d-dave_ceph_5144a679c2c2dc73dca6af55793a3dafdf27fb6f/qa/tasks/cephfs/test_admin.py", line 1870, in test_idem_unaffected_root_squash 2024-04-24T11:21:40.241 INFO:tasks.cephfs_test_runner: self.assertIn(cap, keyring) 2024-04-24T11:21:40.241 INFO:tasks.cephfs_test_runner:AssertionError: 'allow rw fsname=cephfs path=dir1 root_squash' not found in '[client.testuser]\n\tkey = AQA36yhm/eo6HhAA9tPxnKxRhM+lYpDu4q5+FQ==\n\tcaps mds = "allow rw fsname=cephfs path=dir1"\n\tcaps mon = "allow r fsname=cephfs"\n\tcaps osd = "allow rw tag cephfs data=cephfs"\n'
Updated by Rishabh Dave almost 2 years ago
- Related to Bug #66160: qa/cephfs: allow max tests to run in test_admin.py added
Updated by Venky Shankar over 1 year ago
- Category set to Correctness/Safety
- Status changed from New to Need More Info
- Target version set to v20.0.0
- Source set to Q/A
@Rishabh Dave This issue lacks the job link without which its hard to someone to look into the failure. Please update the tracker with the run link.
Updated by Rishabh Dave over 1 year ago
- Description updated (diff)
- Status changed from Need More Info to In Progress
Updated by Rishabh Dave over 1 year ago · Edited
- Pull request ID set to 58543
fs authorize command is not supposed to allow deducting caps, it can only add caps. Regardless of this, current code in merge() method of MDSAuthCaps.cc allows over-writing root_squash. Modifying root_squash from false to true is fine (since addition is allowed) but modifying it from true to false is not allowed (since this would deduct root_squash from the cap).
if (g.match.root_squash != ng.match.root_squash) {
g.match.root_squash = ng.match.root_squash;
}
Allowing modificaion from true to false and disallowing otherwise will fix this bug.
Updated by Rishabh Dave over 1 year ago
- Status changed from In Progress to Fix Under Review
Updated by Venky Shankar over 1 year ago
- Status changed from Fix Under Review to Pending Backport
Updated by Upkeep Bot over 1 year ago
- Copied to Backport #67854: squid: Test failure: test_idem_unaffected_root_squash (tasks.cephfs.test_admin.TestFsAuthorizeUpdate) added
Updated by Upkeep Bot over 1 year ago
- Copied to Backport #67855: reef: Test failure: test_idem_unaffected_root_squash (tasks.cephfs.test_admin.TestFsAuthorizeUpdate) added
Updated by Upkeep Bot over 1 year ago
- Copied to Backport #67856: quincy: Test failure: test_idem_unaffected_root_squash (tasks.cephfs.test_admin.TestFsAuthorizeUpdate) added
Updated by Upkeep Bot over 1 year ago
- Tags (freeform) set to backport_processed
Updated by Rishabh Dave over 1 year ago
- Backport changed from quincy,reef,squid to squid
Updated by Rishabh Dave over 1 year ago
The root cause of this bug is that fs authorzie was allowed to deduct root_squash part from auth caps even though that is not allowed. Since fs authorize command on pre-Squid releases can only create an entity keyring but cannot add caps to it, patches for this ticket doesn't qualify for backporting to pre-Squid releases.
Updated by Rishabh Dave over 1 year ago
- Status changed from Pending Backport to Resolved
Updated by Rishabh Dave over 1 year ago · Edited
Marking this as resolved since Squid backport has been merged and Quincy and Reef backport tickets have been marked as rejected due to https://tracker.ceph.com/issues/65808#note-18.
Updated by Upkeep Bot 9 months ago
- Merge Commit set to f070510eb31e96606b11904fdf54f86c300a6795
- Fixed In set to v19.3.0-4639-gf070510eb31
- Upkeep Timestamp set to 2025-06-30T19:35:48+00:00
Updated by Upkeep Bot 8 months ago
- Fixed In changed from v19.3.0-4639-gf070510eb31 to v19.3.0-4639-gf070510eb3
- Upkeep Timestamp changed from 2025-06-30T19:35:48+00:00 to 2025-07-14T16:45:03+00:00
Updated by Upkeep Bot 5 months ago
- Released In set to v20.2.0~2116
- Upkeep Timestamp changed from 2025-07-14T16:45:03+00:00 to 2025-11-01T01:26:50+00:00
Actions