Project

General

Profile

Actions

Feature #65747

open

common/admin_socket: support saving json output to a file local to the daemon

Added by Patrick Donnelly almost 2 years ago. Updated 5 months ago.

Status:
Pending Backport
Priority:
Normal
Category:
common
Target version:
% Done:

0%

Source:
Development
Backport:
squid,reef,quincy
Reviewed:
Affected Versions:
Pull request ID:
Tags (freeform):
Fixed In:
v19.3.0-2355-g3767887144
Released In:
v20.2.0~2845
Upkeep Timestamp:
2025-11-01T00:54:49+00:00

Description

The ceph tell mds.X cache dump and ceph tell mds.X ops commands have a useful --path argument that directs the daemon to save the dump of the output to a file local the daemon. This has several advantages:

  • We don't need to construct the JSON output in memory, which may be many gigabytes.
  • Streaming writes to a local file is significantly faster than sending the data over the ceph messenger.
  • The command spends as little time as possible holding relevant locks.

However, only some commands support this and we could make it generic to the admin socket interface. So, add a generic --output-file argument to achieve this.

The main concern with this is security (telling the daemon to write to arbitrary files) but this is gated by the session caps which require "allow_all" and that's typically only valid for the client.admin.


Related issues 3 (1 open2 closed)

Copied to Ceph - Backport #66185: squid: common/admin_socket: support saving json output to a file local to the daemonResolvedPatrick DonnellyActions
Copied to Ceph - Backport #66186: quincy: common/admin_socket: support saving json output to a file local to the daemonRejectedPatrick DonnellyActions
Copied to Ceph - Backport #66187: reef: common/admin_socket: support saving json output to a file local to the daemonIn ProgressPatrick DonnellyActions
Actions #1

Updated by Patrick Donnelly almost 2 years ago

  • Status changed from New to In Progress
  • Pull request ID set to 57215
Actions #2

Updated by Patrick Donnelly almost 2 years ago

  • Status changed from In Progress to Pending Backport
Actions #3

Updated by Upkeep Bot almost 2 years ago

  • Copied to Backport #66185: squid: common/admin_socket: support saving json output to a file local to the daemon added
Actions #4

Updated by Upkeep Bot almost 2 years ago

  • Copied to Backport #66186: quincy: common/admin_socket: support saving json output to a file local to the daemon added
Actions #5

Updated by Upkeep Bot almost 2 years ago

  • Copied to Backport #66187: reef: common/admin_socket: support saving json output to a file local to the daemon added
Actions #7

Updated by Upkeep Bot 8 months ago

  • Merge Commit set to 3767887144d6f1556b42b31a9d6142e4725a4909
  • Fixed In set to v19.3.0-2355-g3767887144d
  • Upkeep Timestamp set to 2025-07-08T22:38:53+00:00
Actions #8

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v19.3.0-2355-g3767887144d to v19.3.0-2355-g3767887144
  • Upkeep Timestamp changed from 2025-07-08T22:38:53+00:00 to 2025-07-14T17:10:48+00:00
Actions #9

Updated by Upkeep Bot 5 months ago

  • Released In set to v20.2.0~2845
  • Upkeep Timestamp changed from 2025-07-14T17:10:48+00:00 to 2025-11-01T00:54:49+00:00
Actions

Also available in: Atom PDF