Project

General

Profile

Actions

Bug #65509

closed

osd: remove outdated, incorrect truncate asserts in ECTransaction's generate_transactions

Added by Mark Nelson almost 2 years ago. Updated 5 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
% Done:

100%

Source:
Development
Backport:
squid,reef,quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Tags (freeform):
backport_processed
Fixed In:
v19.3.0-1949-g9a41cd7313
Released In:
v20.2.0~2980
Upkeep Timestamp:
2025-11-01T01:33:48+00:00

Description

User hit this:

    -2> 2024-04-15T21:04:27.546+0000 7f5590204700 20 osd.45 pg_epoch: 1765330 pg[27.51s0( v 1765323'86017025 lc 1764740'86016886 (1762776'86007016,1765323'86017025] local-lis/les=1765329/1765330 n=116000 ec=1429183/1419873 lis/c=1765329/1764739 les/c/f=1765330/1764740/0 sis=1765329) [45,NONE,374,672,635,457,268,579,336,604]p45(0) r=0 lpr=1765329 pi=[1764739,1765329)/2 crt=1765323'86017025 lcod 0'0 mlcod 0'0 active+undersized+degraded rops=2 m=91 mbc={0={(0+0)=31},1={(0+0)=31},2={(1+0)=31},3={(1+0)=31},4={(1+0)=31},5={(1+0)=31},6={(1+0)=31},7={(1+0)=31},8={(1+0)=31},9={(1+0)=31}}] generate_transactions:  truncate is 0,7340032
    -1> 2024-04-15T21:04:27.550+0000 7f5590204700 -1 /home/jenkins-build/build/workspace/ceph-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.2.7/rpm/el8/BUILD/ceph-17.2.7/src/osd/ECTransaction.cc: In function 'ECTransaction::generate_transactions(ECTransaction::WritePlan&, ceph::ErasureCodeInterfaceRef&, pg_t, const ECUtil::stripe_info_t&, const std::map<hobject_t, interval_map<long unsigned int, ceph::buffer::v15_2_0::list, bl_split_merge> >&, std::vector<pg_log_entry_t>&, std::map<hobject_t, interval_map<long unsigned int, ceph::buffer::v15_2_0::list, bl_split_merge> >*, std::map<shard_id_t, ceph::os::Transaction>*, std::set<hobject_t>*, std::set<hobject_t>*, DoutPrefixProvider*, ceph_release_t)::<lambda(std::pair<const hobject_t, PGTransaction::ObjectOperation>&)>' thread 7f5590204700 time 2024-04-15T21:04:27.549205+0000
/home/jenkins-build/build/workspace/ceph-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.2.7/rpm/el8/BUILD/ceph-17.2.7/src/osd/ECTransaction.cc: 208: FAILED ceph_assert(op.truncate->first == op.truncate->second)

Fix in the works.


Related issues 3 (0 open3 closed)

Copied to Ceph - Backport #67131: squid: osd: remove outdated, incorrect truncate asserts in ECTransaction's generate_transactionsRejectedKonstantin ShalyginActions
Copied to Ceph - Backport #67132: reef: osd: remove outdated, incorrect truncate asserts in ECTransaction's generate_transactionsRejectedKonstantin ShalyginActions
Copied to Ceph - Backport #67133: quincy: osd: remove outdated, incorrect truncate asserts in ECTransaction's generate_transactionsResolvedKonstantin ShalyginActions
Actions #2

Updated by Samuel Just almost 2 years ago

  • Priority changed from Normal to High
  • Backport set to squid,reef
Actions #3

Updated by Samuel Just almost 2 years ago

  • Subject changed from Assert in ECTransaction's generate_transactions to osd: remove outdated, incorrect truncate asserts in ECTransaction's generate_transactions
Actions #4

Updated by Samuel Just almost 2 years ago

  • Status changed from New to Fix Under Review
Actions #5

Updated by Radoslaw Zarzynski almost 2 years ago

  • Backport changed from squid,reef to squid,reef,quincy
Actions #6

Updated by Radoslaw Zarzynski almost 2 years ago

Per https://github.com/ceph/ceph/pull/56924#issuecomment-2061948862 a workaround exists:

(...) we could recover the cluster and stay healthy by forcibly disabling trim/discards from clients.

Actions #7

Updated by Dan van der Ster over 1 year ago

  • Status changed from Fix Under Review to Pending Backport
  • Pull request ID set to 56924
Actions #8

Updated by Upkeep Bot over 1 year ago

  • Copied to Backport #67131: squid: osd: remove outdated, incorrect truncate asserts in ECTransaction's generate_transactions added
Actions #9

Updated by Upkeep Bot over 1 year ago

  • Copied to Backport #67132: reef: osd: remove outdated, incorrect truncate asserts in ECTransaction's generate_transactions added
Actions #10

Updated by Upkeep Bot over 1 year ago

  • Copied to Backport #67133: quincy: osd: remove outdated, incorrect truncate asserts in ECTransaction's generate_transactions added
Actions #11

Updated by Upkeep Bot over 1 year ago

  • Tags (freeform) set to backport_processed
Actions #12

Updated by Konstantin Shalygin over 1 year ago

  • Assignee set to Mark Nelson
  • Source set to Development
Actions #13

Updated by Konstantin Shalygin about 1 year ago

  • Status changed from Pending Backport to Resolved
  • Target version set to v20.0.0
  • % Done changed from 0 to 100
Actions #14

Updated by Upkeep Bot 8 months ago

  • Merge Commit set to 9a41cd7313f2019ae9c13c644a1b4547647a8b07
  • Fixed In set to v19.3.0-1949-g9a41cd7313f
  • Upkeep Timestamp set to 2025-07-11T12:49:57+00:00
Actions #15

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v19.3.0-1949-g9a41cd7313f to v19.3.0-1949-g9a41cd7313
  • Upkeep Timestamp changed from 2025-07-11T12:49:57+00:00 to 2025-07-14T23:09:33+00:00
Actions #16

Updated by Upkeep Bot 5 months ago

  • Released In set to v20.2.0~2980
  • Upkeep Timestamp changed from 2025-07-14T23:09:33+00:00 to 2025-11-01T01:33:48+00:00
Actions

Also available in: Atom PDF