Project

General

Profile

Actions
Copy link

Bug #65176

closed

BlueFS: _estimate_log_size_N calculates the log size incorrectly

Added by linke wang almost 2 years ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
linke wang
Category:
-
Target version:
v20.0.0
% Done:

0%

Source:
Community (user)
Backport:
squid, reef
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
56515
Crash signature (v1):
Crash signature (v2):
Tags (freeform):
backport_processed
Merge Commit:
1d815ceabb47f66b7ffcffd2e7bff487b4bab808
Fixed In:
v19.3.0-1987-g1d815ceabb
Released In:
v20.2.0~2966
Upkeep Timestamp:
2025-11-01T01:33:58+00:00

Description

In BlueFS::_estimate_log_size_N, the total size of the dir was calculated incorrectly.
It should be the number of dirs multiplied by (avg_size+1).

Related issues 2 (0 open — 2 closed)

Copied to Ceph - Backport #70067: squid: BlueFS: _estimate_log_size_N calculates the log size incorrectlyResolvedKonstantin ShalyginActions
Copied to Ceph - Backport #70068: reef: BlueFS: _estimate_log_size_N calculates the log size incorrectlyResolvedKonstantin ShalyginActions
Actions
Copy link
 #1

Updated by Igor Fedotov almost 2 years ago

  • Status changed from New to In Progress
  • Backport set to squid, reef, quincy
Actions
Copy link
 #2

Updated by linke wang almost 2 years ago

Does avg_dir_size or avg_file_size represent the meaning of the bytes occupied by the name? Or does it have other meanings? @ Igor Fedotov

Actions
Copy link
 #3

Updated by Igor Fedotov almost 2 years ago

linke wang wrote in #note-2:

Does avg_dir_size or avg_file_size represent the meaning of the bytes occupied by the name? Or does it have other meanings? @ Igor Fedotov

Yeah, looks like they represent bytes occupied for names. Not sure I understand why we sum avg_dir_size and avg_file_size for the following line though:
size += nodes.file_map.size() * (1 + avg_dir_size + avg_file_size);

Actions
Copy link
 #4

Updated by linke wang almost 2 years ago

What is calculated here should be the total bytes occupied by the names of all files.@ Igor Fedotov

Actions
Copy link
 #5

Updated by linke wang almost 2 years ago

  • % Done changed from 0 to 100
Actions
Copy link
 #6

Updated by Konstantin Shalygin about 1 year ago

  • Backport changed from squid, reef, quincy to squid, reef
Actions
Copy link
 #7

Updated by Konstantin Shalygin about 1 year ago

  • Status changed from In Progress to Pending Backport
  • Assignee set to linke wang
  • Target version set to v20.0.0
  • % Done changed from 100 to 0
  • Source set to Community (user)
Actions
Copy link
 #8

Updated by Upkeep Bot about 1 year ago

  • Copied to Backport #70067: squid: BlueFS: _estimate_log_size_N calculates the log size incorrectly added
Actions
Copy link
 #9

Updated by Upkeep Bot about 1 year ago

  • Copied to Backport #70068: reef: BlueFS: _estimate_log_size_N calculates the log size incorrectly added
Actions
Copy link
 #10

Updated by Upkeep Bot about 1 year ago

  • Tags (freeform) set to backport_processed
Actions
Copy link
 #11

Updated by Konstantin Shalygin about 1 year ago

  • Status changed from Pending Backport to Resolved
Actions
Copy link
 #12

Updated by Upkeep Bot 8 months ago

  • Merge Commit set to 1d815ceabb47f66b7ffcffd2e7bff487b4bab808
  • Fixed In set to v19.3.0-1987-g1d815ceabb4
  • Upkeep Timestamp set to 2025-07-11T13:50:38+00:00
Actions
Copy link
 #13

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v19.3.0-1987-g1d815ceabb4 to v19.3.0-1987-g1d815ceabb
  • Upkeep Timestamp changed from 2025-07-11T13:50:38+00:00 to 2025-07-14T23:09:54+00:00
Actions
Copy link
 #14

Updated by Upkeep Bot 5 months ago

  • Released In set to v20.2.0~2966
  • Upkeep Timestamp changed from 2025-07-14T23:09:54+00:00 to 2025-11-01T01:33:58+00:00
Actions
Copy link

Also available in: Atom PDF