Project

General

Profile

Actions

Bug #64799

open

mgr: update cluster state for new maps from the mons before notifying modules

Added by Patrick Donnelly about 2 years ago. Updated 5 months ago.

Status:
Pending Backport
Priority:
Normal
Category:
ceph-mgr
Target version:
% Done:

0%

Source:
Development
Backport:
squid,reef,quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Tags (freeform):
Fixed In:
v19.3.0-1665-gf34b439d62
Released In:
v20.2.0~3066
Upkeep Timestamp:
2025-11-01T00:55:20+00:00

Description

https://github.com/ceph/ceph/blob/639d182732644edc5c413562ebc904ab5b953303/src/mgr/Mgr.cc#L590-L597

Oddly the maps are processed after notifying the modules. I'm not sure if this actually can cause modules to read from the old maps (since finisher contexts are queued) but it seemed odd.


Related issues 3 (1 open2 closed)

Copied to mgr - Backport #65621: quincy: mgr: update cluster state for new maps from the mons before notifying modulesIn ProgressPatrick DonnellyActions
Copied to mgr - Backport #65622: squid: mgr: update cluster state for new maps from the mons before notifying modulesResolvedPatrick DonnellyActions
Copied to mgr - Backport #65623: reef: mgr: update cluster state for new maps from the mons before notifying modulesResolvedPatrick DonnellyActions
Actions #1

Updated by Patrick Donnelly about 2 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 56047
Actions #2

Updated by Radoslaw Zarzynski almost 2 years ago

Per let's not hurry up with backporting this chnage. IMHO it deserves some baking in `main`.:

let's not hurry up with backporting this chnage. IMHO it deserves some baking in `main`.

Actions #3

Updated by Patrick Donnelly almost 2 years ago

  • Status changed from Fix Under Review to Pending Backport

I'll sit on the backports for a while.

Actions #4

Updated by Upkeep Bot almost 2 years ago

  • Copied to Backport #65621: quincy: mgr: update cluster state for new maps from the mons before notifying modules added
Actions #5

Updated by Upkeep Bot almost 2 years ago

  • Copied to Backport #65622: squid: mgr: update cluster state for new maps from the mons before notifying modules added
Actions #6

Updated by Upkeep Bot almost 2 years ago

  • Copied to Backport #65623: reef: mgr: update cluster state for new maps from the mons before notifying modules added
Actions #8

Updated by Upkeep Bot 8 months ago

  • Merge Commit set to f34b439d626621df3f67d8d20162d581836003cb
  • Fixed In set to v19.3.0-1665-gf34b439d626
  • Upkeep Timestamp set to 2025-07-09T13:47:27+00:00
Actions #9

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v19.3.0-1665-gf34b439d626 to v19.3.0-1665-gf34b439d62
  • Upkeep Timestamp changed from 2025-07-09T13:47:27+00:00 to 2025-07-14T17:41:09+00:00
Actions #10

Updated by Upkeep Bot 5 months ago

  • Released In set to v20.2.0~3066
  • Upkeep Timestamp changed from 2025-07-14T17:41:09+00:00 to 2025-11-01T00:55:20+00:00
Actions

Also available in: Atom PDF