Project

General

Profile

Actions

Bug #63891

open

mon/AuthMonitor: fix potential repeated global_id

Added by Min Shi about 2 years ago. Updated about 1 year ago.

Status:
Fix Under Review
Priority:
Normal
Assignee:
Category:
Correctness/Safety
Target version:
% Done:

0%

Source:
Community (dev)
Backport:
squid,reef
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Monitor
Pull request ID:
Tags (freeform):
Merge Commit:
Fixed In:
Released In:
Upkeep Timestamp:

Description

When we expand or shrink monitors, there is the possibility of repeatedly allocating global ids. Because the calculation of last_allocated_id depends on mon_num and mon_rank, and expand or shrink monitors changes mon_num and mon_rank. A simple fix is to reset last_allocated_id when the election is complete.

Actions #1

Updated by Min Shi about 2 years ago

does anyone see this issue?

Actions #2

Updated by Radoslaw Zarzynski almost 2 years ago

  • Status changed from New to Fix Under Review

Bump up.

Actions #3

Updated by Min Shi almost 2 years ago

cephfs client depend on global_id, and repeated global_id would result some inconsistent problem

Actions #4

Updated by Radoslaw Zarzynski almost 2 years ago

Bump up.

Actions #5

Updated by Patrick Donnelly over 1 year ago

  • Category set to Correctness/Safety
  • Assignee set to Min Shi
  • Target version set to v20.0.0
  • Source set to Community (dev)
  • Backport set to squid,reef,quincy
  • Component(RADOS) Monitor added
Actions #6

Updated by Radoslaw Zarzynski over 1 year ago

scrub note: undergoes QA.

Actions #7

Updated by Radoslaw Zarzynski over 1 year ago

scrub note: review of QA results is in progress.

Actions #8

Updated by Konstantin Shalygin about 1 year ago

  • Backport changed from squid,reef,quincy to squid,reef
Actions #9

Updated by Radoslaw Zarzynski about 1 year ago

scrub the fix has caused some failures in the QA. Since then waiting for rework.

Actions

Also available in: Atom PDF