Bug #63288
closedMClientRequest: properly handle ceph_mds_request_head_legacy for ext_num_retry, ext_num_fwd, owner_uid, owner_gid
100%
Description
If cephfs client is old enough (for example Linux kernel 5.4 cephfs client) and uses struct ceph_mds_request_head_legacy,
then MDS server won't handle ext_num_retry, ext_num_fwd, owner_uid, owner_gid fields properly. They are left uninitialized
which leads to serious issues.
- In case of owner_uid, owner_gid it leads to the MDS crash on assertion [ ceph_assert(_inode->gid != (unsigned)-1) ].
- For ext_num_retry, ext_num_fwd it's hard to notice any issue but from the code I can see that issue is present. (I hope that Xiubo Li will check me there.)
Issue was originally discovered by Venky Shankar https://github.com/ceph/ceph/pull/53139#issuecomment-1771388202 during testing of the Quincy release.
After some investigation I was able to find a bug in the code, then reproduce it on my local environment and prepare the PR for the main branch (https://github.com/ceph/ceph/pull/54149).
But we will need to (partially) backport this to older cephfs releases.
Updated by Patrick Donnelly over 2 years ago
- Related to Bug #62217: ceph_fs.h: add separate owner_{u,g}id fields added
Updated by Rishabh Dave over 2 years ago
- Status changed from New to Pending Backport
Updated by Upkeep Bot over 2 years ago
- Copied to Backport #63476: reef: MClientRequest: properly handle ceph_mds_request_head_legacy for ext_num_retry, ext_num_fwd, owner_uid, owner_gid added
Updated by Upkeep Bot over 2 years ago
- Copied to Backport #63477: quincy: MClientRequest: properly handle ceph_mds_request_head_legacy for ext_num_retry, ext_num_fwd, owner_uid, owner_gid added
Updated by Upkeep Bot over 2 years ago
- Copied to Backport #63478: pacific: MClientRequest: properly handle ceph_mds_request_head_legacy for ext_num_retry, ext_num_fwd, owner_uid, owner_gid added
Updated by Konstantin Shalygin about 2 years ago
- Status changed from Pending Backport to Resolved
- % Done changed from 90 to 100
Updated by Upkeep Bot 8 months ago
- Merge Commit set to 665e6926576f3b98395185741aa6c213336ed4bc
- Fixed In set to v18.0.0-7212-g665e6926576
- Released In set to v19.2.0~1261
- Upkeep Timestamp set to 2025-07-11T21:11:44+00:00