Project

General

Profile

Actions

Bug #58607

closed

osd: PushOp and PullOp costs for mClock don't reflect the size of the object leading to degraded recovery performance.

Added by Sridhar Seshasayee about 3 years ago. Updated 8 months ago.

Status:
Resolved
Priority:
Normal
Category:
Performance/Resource Usage
Target version:
-
% Done:

0%

Source:
Backport:
quincy, reef
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
OSD
Pull request ID:
Tags (freeform):
Fixed In:
v18.0.0-3828-ga9d46ad6dd1
Released In:
v19.2.0~2398
Upkeep Timestamp:
2025-07-12T18:43:39+00:00

Description

Currently, PullOp cost is set to the following:

uint64_t PullOp::cost(CephContext *cct) const
{
  return cct->_conf->osd_push_per_object_cost +
    cct->_conf->osd_recovery_max_chunk;
}

See:
https://github.com/ceph/ceph/blob/d33a2a9181435d8834586f02a41e0cc49d6dd4b6/src/osd/osd_types.cc#L6775

In addition, the cost could be further aggregated based on the
number of PullOp items in MOSDPGPull message.

However, PushOp cost appears to reflect a little over the object size and
therefore, this may not need any change for mClock but will need to
be verified.

See: https://github.com/ceph/ceph/blob/d33a2a9181435d8834586f02a41e0cc49d6dd4b6/src/osd/osd_types.cc#L6872


Related issues 2 (0 open2 closed)

Copied to RADOS - Backport #62133: reef: osd: PushOp and PullOp costs for mClock don't reflect the size of the object leading to degraded recovery performance.ResolvedSridhar SeshasayeeActions
Copied to RADOS - Backport #62134: quincy: osd: PushOp and PullOp costs for mClock don't reflect the size of the object leading to degraded recovery performance.ResolvedSridhar SeshasayeeActions
Actions #1

Updated by Sridhar Seshasayee about 3 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 49975
Actions #2

Updated by Sridhar Seshasayee over 2 years ago

  • Status changed from Fix Under Review to Pending Backport
  • Backport set to quincy, reef
Actions #3

Updated by Upkeep Bot over 2 years ago

  • Copied to Backport #62133: reef: osd: PushOp and PullOp costs for mClock don't reflect the size of the object leading to degraded recovery performance. added
Actions #4

Updated by Upkeep Bot over 2 years ago

  • Copied to Backport #62134: quincy: osd: PushOp and PullOp costs for mClock don't reflect the size of the object leading to degraded recovery performance. added
Actions #6

Updated by Sridhar Seshasayee over 2 years ago

  • Status changed from Pending Backport to Resolved
Actions #7

Updated by Upkeep Bot 8 months ago

  • Merge Commit set to a9d46ad6dd12efb51ffa29ef12be6b19761a0911
  • Fixed In set to v18.0.0-3828-ga9d46ad6dd1
  • Released In set to v19.2.0~2398
  • Upkeep Timestamp set to 2025-07-12T18:43:39+00:00
Actions

Also available in: Atom PDF