Project

General

Profile

Actions

Bug #55144

closed

client: stop retrying the request when exceeding 256 times

Added by Xiubo Li almost 4 years ago. Updated 8 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

100%

Source:
Backport:
quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Client
Labels (FS):
Pull request ID:
Tags (freeform):
backport_processed
Fixed In:
v17.0.0-12457-g90ff84d0acc
Released In:
v18.2.0~2135
Upkeep Timestamp:
2025-07-14T05:13:50+00:00

Description

The type of 'r_attempts' in kernel 'ceph_mds_request' is 'int',
while in 'ceph_mds_request_head' the type of 'num_retry' is '__u8'.
So in case the request retries exceeding 256 times, the MDS will
receive a incorrect retry seq.

In this case it's ususally a bug in MDS and continue retrying the
request makes no sense. For now let's limit it to 256. In future
this could be fixed in ceph code, so avoid using the hardcode here.


Related issues 1 (0 open1 closed)

Copied to CephFS - Backport #67482: quincy: client: stop retrying the request when exceeding 256 times RejectedXiubo LiActions
Actions #1

Updated by Xiubo Li almost 4 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 45728
Actions #2

Updated by Konstantin Shalygin over 1 year ago

  • Backport changed from quincy,pacific to quincy
Actions #3

Updated by Konstantin Shalygin over 1 year ago

  • Status changed from Fix Under Review to Pending Backport
Actions #4

Updated by Upkeep Bot over 1 year ago

  • Copied to Backport #67482: quincy: client: stop retrying the request when exceeding 256 times added
Actions #5

Updated by Upkeep Bot over 1 year ago

  • Tags (freeform) set to backport_processed
Actions #6

Updated by Konstantin Shalygin about 1 year ago

  • Status changed from Pending Backport to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Upkeep Bot 8 months ago

  • Merge Commit set to 90ff84d0acc006ba1d94fe587da12fe6c6008244
  • Fixed In set to v17.0.0-12457-g90ff84d0acc
  • Released In set to v18.2.0~2135
  • Upkeep Timestamp set to 2025-07-14T05:13:50+00:00
Actions

Also available in: Atom PDF