Project

General

Profile

Actions

Bug #54528

open

cls_rgw_suggest_changes() may accidentally delete newly-completed entries

Added by Casey Bodley about 4 years ago. Updated 8 months ago.

Status:
Pending Backport
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Source:
Backport:
octopus pacific quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Tags (freeform):
Fixed In:
v17.0.0-11181-g26cc3fd6b5
Released In:
v18.2.0~2543
Upkeep Timestamp:
2025-07-14T20:43:53+00:00

Description

if bucket listing races with a pending index transaction, its suggested removal may be mistakenly applied if that index transaction completes before the osd receives this suggestion

in rgw_dir_suggest_changes(), the sole condition for applying a suggested change is that the cur_disk.pending_map is empty. this is true after rgw_bucket_complete_op()

racing sequence of events in cls/rgw:

rgw_bucket_prepare_op() adds entry to pending_map

rgw_bucket_list() returns entry with pending_map

rgw_bucket_complete_op() completes entry, clears pending_map

rgw_dir_suggest_changes() finds pending_map empty, so applies a suggestion to remove the listed entry


Related issues 3 (0 open3 closed)

Copied to rgw - Backport #55043: quincy: cls_rgw_suggest_changes() may accidentally delete newly-completed entriesResolvedJ. Eric IvancichActions
Copied to rgw - Backport #55044: pacific: cls_rgw_suggest_changes() may accidentally delete newly-completed entriesResolvedJ. Eric IvancichActions
Copied to rgw - Backport #55045: octopus: cls_rgw_suggest_changes() may accidentally delete newly-completed entriesResolvedJ. Eric IvancichActions
Actions #1

Updated by Casey Bodley almost 4 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #2

Updated by Upkeep Bot almost 4 years ago

  • Copied to Backport #55043: quincy: cls_rgw_suggest_changes() may accidentally delete newly-completed entries added
Actions #3

Updated by Upkeep Bot almost 4 years ago

  • Copied to Backport #55044: pacific: cls_rgw_suggest_changes() may accidentally delete newly-completed entries added
Actions #4

Updated by Upkeep Bot almost 4 years ago

  • Copied to Backport #55045: octopus: cls_rgw_suggest_changes() may accidentally delete newly-completed entries added
Actions #6

Updated by Upkeep Bot 9 months ago

  • Merge Commit set to 26cc3fd6b5fc4415b3ffd31d81ef41f2d4273dea
  • Fixed In set to v17.0.0-11181-g26cc3fd6b5f
  • Released In set to v18.2.0~2543
  • Upkeep Timestamp set to 2025-07-09T17:10:44+00:00
Actions #7

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v17.0.0-11181-g26cc3fd6b5f to v17.0.0-11181-g26cc3fd6b5
  • Upkeep Timestamp changed from 2025-07-09T17:10:44+00:00 to 2025-07-14T20:43:53+00:00
Actions

Also available in: Atom PDF