Project

General

Profile

Actions
Copy link

Bug #48152

closed

mgr_test_case: skipTest is an instance method, not a class method

Added by Rishabh Dave over 5 years ago. Updated 8 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Rishabh Dave
Category:
-
Target version:
-
% Done:

0%

Source:
Backport:
octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
37992
Tags (freeform):
Merge Commit:
f7962b176725682ea49c25c24ee8981730eb5085
Fixed In:
v16.0.0-7168-gf7962b1767
Released In:
v16.2.0~852
Upkeep Timestamp:
2025-07-14T19:24:51+00:00

Description

When the block calling skipTest() (as class method) is executed, following traceback can be found -

2020-11-09 18:24:29,193.193 INFO:__main__:======================================================================
2020-11-09 18:24:29,193.193 INFO:__main__:ERROR: setUpClass (tasks.mgr.test_dashboard.TestDashboard)
2020-11-09 18:24:29,193.193 INFO:__main__:----------------------------------------------------------------------
2020-11-09 18:24:29,193.193 INFO:__main__:Traceback (most recent call last):
2020-11-09 18:24:29,193.193 INFO:__main__:  File "/home/rishabh/repos/ceph/minor/qa/tasks/mgr/mgr_test_case.py", line 102, in setUpClass
2020-11-09 18:24:29,193.193 INFO:__main__:    if len(cls.mgr_cluster.mgr_ids) < cls.MGRS_REQUIRED:
2020-11-09 18:24:29,193.193 INFO:__main__:TypeError: skipTest() missing 1 required positional argument: 'reason'

unittest.TestCase.skipTest() is an instance method and not a class method. So the "reason" provided as str ends up being accepted as the instance and therefore, the call is short of one parameter.

Related issues 1 (0 open — 1 closed)

Copied to mgr - Backport #48279: octopus: mgr_test_case: skipTest is an instance method, not a class methodResolvedRishabh DaveActions
Actions
Copy link
 #1

Updated by Rishabh Dave over 5 years ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link
 #2

Updated by Rishabh Dave over 5 years ago

  • Status changed from Resolved to Fix Under Review
Actions
Copy link
 #3

Updated by Rishabh Dave over 5 years ago

  • Status changed from Fix Under Review to Pending Backport

Since Kefu recommends creating backports - https://github.com/ceph/ceph/pull/37992#issuecomment-729690559.

Actions
Copy link
 #4

Updated by Rishabh Dave over 5 years ago

  • Backport set to octopus
Actions
Copy link
 #5

Updated by Rishabh Dave over 5 years ago

  • Copied to Backport #48279: octopus: mgr_test_case: skipTest is an instance method, not a class method added
Actions
Copy link
 #6

Updated by Nathan Cutler about 5 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link
 #7

Updated by Upkeep Bot 8 months ago

  • Merge Commit set to f7962b176725682ea49c25c24ee8981730eb5085
  • Fixed In set to v16.0.0-7168-gf7962b1767
  • Released In set to v16.2.0~852
  • Upkeep Timestamp set to 2025-07-14T19:24:51+00:00
Actions
Copy link

Also available in: Atom PDF