Project

General

Profile

Actions
Copy link

Cleanup #45321

closed

Servcie spec: unify `spec:` vs omitting `spec:`

Added by Sebastian Wagner almost 6 years ago. Updated 8 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Ceph - v15.2.5
% Done:

0%

Backport:
Reviewed:
Affected Versions:
Pull request ID:
35537
Tags (freeform):
Merge Commit:
c5239d8ca3d284794a86dca00d2182234a91d07a
Fixed In:
v16.0.0-2926-gc5239d8ca3
Released In:
v16.2.0~2163
Upkeep Timestamp:
2025-07-15T01:13:13+00:00

Description

service_type: iscsi 
service_id: test
placement:
  hosts:
    - osd0
spec:
  pool: rbd
  api_user: admin
  api_password: admin
  trusted_ip_list: 192.168.121.1

service_type: iscsi 
service_id: test
placement:
  hosts:
    - osd0
pool: rbd
api_user: admin
api_password: admin
trusted_ip_list: 192.168.121.1

are the same data. we should unify them to one or the other.

This is is especially relevant for OSD specs.

Actions
Copy link
 #1

Updated by Sebastian Wagner almost 6 years ago

decison was to use spec

Actions
Copy link
 #2

Updated by Sebastian Wagner almost 6 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 35537
Actions
Copy link
 #3

Updated by Sebastian Wagner over 5 years ago

  • Status changed from Fix Under Review to Resolved
  • Target version set to v15.2.5
Actions
Copy link
 #4

Updated by Upkeep Bot 8 months ago

  • Merge Commit set to c5239d8ca3d284794a86dca00d2182234a91d07a
  • Fixed In set to v16.0.0-2926-gc5239d8ca3
  • Released In set to v16.2.0~2163
  • Upkeep Timestamp set to 2025-07-15T01:13:13+00:00
Actions
Copy link

Also available in: Atom PDF