Feature #44783: c-v's batch report doesn't show if the disk is going to be encrypted - ceph-volume - Ceph

Actions

Copy link

Feature #44783

closed

c-v's batch report doesn't show if the disk is going to be encrypted

Added by Joshua Schmid almost 6 years ago. Updated 8 months ago.

Status:

Resolved

Priority:

Normal

Assignee:

Target version:

Ceph - v15.0.0

% Done:

Source:

Development

Backport:

Reviewed:

Affected Versions:

Pull request ID:

34740

Tags (freeform):

Merge Commit:

239c4bc8f3c14f892656264789217b6b80e12982

Fixed In:

v16.0.0-6063-g239c4bc8f3

Released In:

v16.2.0~1197

Upkeep Timestamp:

2025-07-15T01:16:47+00:00

Description

/usr/sbin/ceph-volume lvm batch --no-auto /dev/vdb --dmcrypt --report --format json

gives

{
    "changed": true,
    "osds": [
        {
            "block.db": {},
            "data": {
                "human_readable_size": "24.00 GB",
                "parts": 1,
                "path": "/dev/vdb",
                "percentage": 100.0,
                "size": 24
            }
        }
    ],
    "vgs": []
}

which is missing the `encrypted` flag.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Jan Fajerski almost 6 years ago

Subject changed from c-v's report doesn't show if the disk is going to be encrypted to c-v's batch report doesn't show if the disk is going to be encrypted

Actions

Copy link

Updated by Jan Fajerski almost 6 years ago

Tracker changed from Bug to Feature

Changing this to a feature.

I'd like input on what you'd expect. An encrypted, but where? Under the 'data' key, under the OSD key? Should be be false in case of unencrypted or missing?

I'd propose an new 'encrypted' key under 'data' that is either false or true.

Actions

Copy link

Updated by Joshua Schmid almost 6 years ago

I assume that --dmcrypt is a block key that will affect all provided disks.
If that's the case, it would suffice to put it one layer above, on the same level as "changed" and "osds"

I don't know how c-v treat external db/wals when this flag is provided. If these LVs are not encrypted we might be better off, being more granular by putting it into the 'data' struct.

Actions

Copy link