Skip to content

closes #4633#4977

Merged
tony-sull merged 2 commits intomainfrom
fix/route-cache-warning
Oct 4, 2022
Merged

closes #4633#4977
tony-sull merged 2 commits intomainfrom
fix/route-cache-warning

Conversation

@tony-sull
Copy link
Copy Markdown
Contributor

Changes

Closes #4633

The cache used for getStaticPaths() will warn if it's called a second time for the same route. This PR updates the warning to only be logged in production builds since HMR will trigger a cache invalidation in dev

Testing

All existing tests should pass - no new tests since it's just a logger fix

Docs

None, logging bug fix only

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 4, 2022

🦋 Changeset detected

Latest commit: bf23b58

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 4, 2022
@tony-sull tony-sull force-pushed the fix/route-cache-warning branch from 5260a24 to bf23b58 Compare October 4, 2022 15:00
Copy link
Copy Markdown
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@tony-sull tony-sull merged commit 4f73b98 into main Oct 4, 2022
@tony-sull tony-sull deleted the fix/route-cache-warning branch October 4, 2022 16:16
@astrobot-houston astrobot-houston mentioned this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Odd error message during development:"Internal Warning: route cache overwritten"

2 participants