feat: overlay displays unhandled promise rejection#4849
Merged
alexander-akait merged 1 commit intowebpack:masterfrom May 7, 2023
Merged
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4849 +/- ##
==========================================
- Coverage 91.96% 91.84% -0.12%
==========================================
Files 16 16
Lines 1704 1704
Branches 647 647
==========================================
- Hits 1567 1565 -2
- Misses 126 128 +2
Partials 11 11 ☔ View full report in Codecov by Sentry. |
alexander-akait
approved these changes
May 7, 2023
Contributor
|
How do I make unhandled promise rejection not overlay displays, so that it behaves the same as before. |
Contributor
overlay: {
++runtimeErrors: false,
errors: true,
warnings: false,
},This is the same behavior as before. |
|
This feature gave us so much headache that we had to downgrade to the previous version. |
Member
|
@keremcanb just disable it using options |
|
We are running on CRA, which is not ejected. Also we don't want to disable
all runtime error messages.
…On Wed, May 31, 2023, 21:58 Alexander Akait ***@***.***> wrote:
@keremcanb <https://github.com/keremcanb> just disable it using options
—
Reply to this email directly, view it on GitHub
<#4849 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOTCKFLRXSYOV22F7ZKVAKTXI5MB5ANCNFSM6AAAAAAXYT23FA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
You can filter them, sorry we will not remove this feature |
|
It should be break change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
overlay.runtimeErrorsshould capture unhandled Promise rejection, as it's still runtime error, just async in nature.Breaking Changes
Not breaking change.
Additional Info
Part of #3689