fix: --config-name behaviour for fuctional configs #2006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47cacb6 to
6284a55
Compare
6284a55 to
a09b338
Compare
Member
Author
|
/cc @webpack/cli-team |
snitin315
commented
Nov 2, 2020
746fcb4 to
7bc69cf
Compare
Member
Author
|
Should be good now. |
rishabh3112
previously approved these changes
Nov 3, 2020
andersk
reviewed
Nov 3, 2020
| return rawConfig; | ||
| }), | ||
| ); | ||
| ).then((allConfigs) => { |
Member
There was a problem hiding this comment.
Avoid using then, we can use async/await safely, I think we need eslint rule for this
Member
alexander-akait
left a comment
There was a problem hiding this comment.
Anyway good job, thanks!
ccc5b37 to
e175cb3
Compare
Member
alexander-akait
left a comment
There was a problem hiding this comment.
Let's fix tests and we can merge
Member
Author
|
Green CI 😄 |
rishabh3112
approved these changes
Nov 3, 2020
alexander-akait
approved these changes
Nov 3, 2020
Member
alexander-akait
left a comment
There was a problem hiding this comment.
/cc @webpack/cli-team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
yes
If relevant, did you update the documentation?
No
Summary
Fixes #1990
Does this PR introduce a breaking change?
No
Other information