Skip to content

chore: deps update#16919

Merged
TheLarkInn merged 19 commits intomainfrom
chore-update-deps
Apr 6, 2023
Merged

chore: deps update#16919
TheLarkInn merged 19 commits intomainfrom
chore-update-deps

Conversation

@alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Apr 6, 2023

update deps regarding to semver

Okay, we have problems with:

  • eslint-plugin-jsdoc (one of a transitive package added the exports to package.json field in patch version and eslint-plugin-jsdoc can't get jsdocs tokens inside file)
  • eslint-plugin-prettier (they added engines in the patch release)
  • lint-staged changed own deps and one of the deps requires node v14
  • ajv + terser - now we have the $id in some schemas, previously terser remove them (we need to fix it in webpack/tooling)

Summary

🤖 Generated by Copilot at 49e15a7

This pull request refactors and improves the schemas for various webpack plugins, using the definitions keyword to define common types and the properties keyword to specify object properties. This makes the schemas more concise, readable, consistent and maintainable.

Details

🤖 Generated by Copilot at 49e15a7

  • Refactor schemas for plugin options to use definitions and properties keywords for better readability and validation (link, link, link)
  • Extract SharedItem schema to avoid duplication and reference it in SharePlugin options schema (link)

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@snitin315
Copy link
Member

Oh I also tried it, I think we need update snapshots too.

@alexander-akait
Copy link
Member Author

@snitin315 Yea, there is some other problems, let's ship this first, and then will ship your PRs with minor/major updates

@alexander-akait
Copy link
Member Author

Because I need this for jest

@alexander-akait
Copy link
Member Author

Copilot can look into minified code, that is great 😄

@alexander-akait
Copy link
Member Author

alexander-akait commented Apr 6, 2023

Okay, we have problems with:

  • eslint-plugin-jsdoc (one of a transitive package added the exports to package.json field in patch version and eslint-plugin-jsdoc can't get jsdocs tokens inside file)
  • eslint-plugin-prettier (they added engines in the patch release)
  • lint-staged changed own deps and one of the deps requires node v14
  • ajv + terser - now we have the $id in some schemas, previously terser remove it (we need to fix it in webpack/tooling)

Copy link
Member

@TheLarkInn TheLarkInn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

This was referenced Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants