Skip to content

fix #16561#16562

Merged
TheLarkInn merged 12 commits intowebpack:mainfrom
long76:patch-1
Apr 5, 2023
Merged

fix #16561#16562
TheLarkInn merged 12 commits intowebpack:mainfrom
long76:patch-1

Conversation

@long76
Copy link
Contributor

@long76 long76 commented Dec 14, 2022 •
edited by TheLarkInn
Loading

What kind of change does this PR introduce?
see #16561

Did you add tests for your changes?
no

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?
add globalObject option to page with amd library plugin

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 14, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@webpack-bot
Copy link
Contributor

webpack-bot commented Dec 14, 2022 •
edited by TheLarkInn
Loading

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@long76
Copy link
Contributor Author

long76 commented Dec 14, 2022

please fix last 2 lint error i worked with ide github

alexander-akait
alexander-akait reviewed Dec 14, 2022
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests

@long76
Copy link
Contributor Author

long76 commented Dec 19, 2022

Please add tests

ok i need some time

@long76
Copy link
Contributor Author

long76 commented Jan 2, 2023

Please add tests

done, param name changed to amdContainer

@alexander-akait
Copy link
Member

alexander-akait commented Mar 16, 2023

@TheLarkInn Makse sense to look at this too, don't see somethinb bad here

TheLarkInn
TheLarkInn approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@TheLarkInn TheLarkInn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution 🚀

@TheLarkInn TheLarkInn enabled auto-merge March 21, 2023 17:44
@TheLarkInn TheLarkInn disabled auto-merge March 21, 2023 17:44
@TheLarkInn TheLarkInn enabled auto-merge March 21, 2023 17:46
@alexander-akait
Copy link
Member

alexander-akait commented Mar 22, 2023

@TheLarkInn Unmerged due 3 failing checks, but there are no problems with other tests

@long76
Copy link
Contributor Author

long76 commented Mar 23, 2023

@TheLarkInn Unmerged due 3 failing checks, but there are no problems with other tests

I can try add more tests for increasing coverage

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 23, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

This was referenced Nov 14, 2023
Open
Open
Open
Closed
Closed
This was referenced Nov 22, 2023
Merged
Merged
Closed
Closed
This was referenced Dec 3, 2023
Closed
Open
This was referenced Dec 12, 2023
Closed
Open
Merged
Merged
@renovate-bot renovate-bot mentioned this pull request Dec 18, 2023
Closed
1 task
This was referenced Dec 21, 2023
Open
Merged
Merged
Closed
This was referenced Jan 2, 2024
Closed
Merged
This was referenced Jan 10, 2024
Closed
Merged
Open
Closed
@renovate renovate bot mentioned this pull request Jan 22, 2024
Merged
1 task
This was referenced Feb 15, 2024
Merged
Closed
@mend-for-github-com mend-for-github-com bot mentioned this pull request Feb 20, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheLarkInn TheLarkInn TheLarkInn approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees

No one assigned

Labels

PR: review-outdated

Projects

webpack 5/6
Status: Shipped

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@long76 @webpack-bot @alexander-akait @TheLarkInn