fix(cli): recursive paths provided by user getting treated non-recursively#828
Merged
passcod merged 1 commit intowatchexec:mainfrom Apr 30, 2024
adit-umakanth:main
Merged
fix(cli): recursive paths provided by user getting treated non-recursively#828passcod merged 1 commit intowatchexec:mainfrom adit-umakanth:main
passcod merged 1 commit intowatchexec:mainfrom
adit-umakanth:main
Conversation
passcod
approved these changes
Apr 30, 2024
Member
passcod
left a comment
There was a problem hiding this comment.
Oh, that's embarrassing. Thanks for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue where I provided a directory using the --watch flag but it gets treated non-recursively:
watchexec -vvv --watch in -- ls -aRelevant log output (with path obscured):
effective watched paths paths=[WatchedPath { path: "..in", recursive: false }]With the change from this PR:
effective watched paths paths=[WatchedPath { path: "..in", recursive: true }]The behavior is now as expected. I'm assuming this was just a missed line when the non-recursive watch feature was added.