Add vue/no-invalid-attribute-name rule#1851
Merged
ota-meshi merged 22 commits intovuejs:masterfrom May 17, 2022
Merged
Conversation
FloEdelmann
requested changes
Apr 16, 2022
Member
|
I don't think the issue has reached consensus. Would you please write your thoughts in the issue? |
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
Contributor
Author
|
Sorry @ota-meshi ; I thought the help wanted tag meant this was shovel-ready. I've updated the ticket with what I found in my investigation, and I'll reopen if we decide if the rule is something we want. |
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
doug-wade
commented
Apr 21, 2022
ota-meshi
requested changes
Apr 21, 2022
Member
ota-meshi
left a comment
There was a problem hiding this comment.
Thank you for changing this PR! I have some requests.
FloEdelmann
requested changes
May 3, 2022
FloEdelmann
reviewed
May 7, 2022
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
FloEdelmann
approved these changes
May 8, 2022
ota-meshi
requested changes
May 9, 2022
ota-meshi
requested changes
May 17, 2022
ota-meshi
approved these changes
May 17, 2022
Member
ota-meshi
left a comment
There was a problem hiding this comment.
I changed this PR because I want to include this rule in the v9 release. Thank you for much work on this PR.
Contributor
Author
|
@ota-meshi thank you so much for taking this one over the line for me. Life just got out of hand, and I really appreciate you getting this into v9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the rule proposed in #1373