Add vue/no-ref-object-destructure rule#1965
Merged
Conversation
FloEdelmann
requested changes
Sep 10, 2022
Member
FloEdelmann
left a comment
There was a problem hiding this comment.
Just a quick look because I don't have time for a full review of this big PR.
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
Member
Author
|
Thank you for the quick review! I have changed the part you commented on. |
FloEdelmann
approved these changes
Sep 10, 2022
Member
FloEdelmann
left a comment
There was a problem hiding this comment.
Thanks, that looks fine now. As noted earlier, I have not looked deeper into the other parts though.
|
This seems to have caused a regression on the import {ref} from 'vue';
const something = false;
let columns;
if (something) {
columns = ref([1]);
} else {
columns = ref([2]);
}This used to be fine, with the new version this causes |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
vue/no-ref-object-destructurerule that reports the destructuring of ref objects causing the value to lose reactivity.close #1949