fix(vitest): skip processing getter in auto-mocked constructor call (#4677)

hi-ogawa · web-flow · commit cb7864aa6068 · 2023-12-06T10:20:05.000+01:00
diff --git a/packages/vitest/src/runtime/mocker.ts b/packages/vitest/src/runtime/mocker.ts
@@ -334,7 +334,11 @@ export class VitestMocker {
             // so that mock states between prototype/instances don't affect each other
             // (jest reference https://github.com/jestjs/jest/blob/2c3d2409879952157433de215ae0eee5188a4384/packages/jest-mock/src/index.ts#L678-L691)
             if (this instanceof newContainer[property]) {
-              for (const { key } of getAllMockableProperties(this, false, primitives)) {
+              for (const { key, descriptor } of getAllMockableProperties(this, false, primitives)) {
+                // skip getter since it's not mocked on prototype as well
+                if (descriptor.get)
+                  continue
+
                 const value = this[key]
                 const type = getType(value)
                 const isFunction = type.includes('Function') && typeof value === 'function'
diff --git a/test/core/src/mockedC.ts b/test/core/src/mockedC.ts
@@ -20,6 +20,10 @@ export class MockedC {
   }
 
   set getSetProp(_val: number) {}
+
+  get getExpectNotCalled(): number {
+    throw new Error('automocked constructor should not call this getter')
+  }
 }
 
 export async function asyncFunc(): Promise<string> {

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,10 @@ export class MockedC {`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`set getSetProp(_val: number) {}`
	`23`	`+`
	`24`	`+ get getExpectNotCalled(): number {`
	`25`	`+ throw new Error('automocked constructor should not call this getter')`
	`26`	`+ }`
`23`	`27`	`}`
`24`	`28`
`25`	`29`	`export async function asyncFunc(): Promise<string> {`