fix(vite-node): coerce to string in import(dep) (#3430)

jcbhmr · sheremet-va · web-flow · commit b72ebdb9132a · 2023-05-25T11:27:29.000+02:00
Co-authored-by: Vladimir &lt;sleuths.slews0s@icloud.com&gt;
diff --git a/packages/vite-node/src/client.ts b/packages/vite-node/src/client.ts
@@ -267,7 +267,7 @@ export class ViteNodeRunner {
     const mod = this.moduleCache.getByModuleId(moduleId)
 
     const request = async (dep: string) => {
-      const [id, depFsPath] = await this.resolveUrl(dep, fsPath)
+      const [id, depFsPath] = await this.resolveUrl(`${dep}`, fsPath)
       return this.dependencyRequest(id, depFsPath, callstack)
     }
 
diff --git a/test/core/test/imports.test.ts b/test/core/test/imports.test.ts
@@ -52,6 +52,12 @@ test('data with dynamic import works', async () => {
   expect(hi).toBe('hi')
 })
 
+test('dynamic import coerces to string', async () => {
+  const dataUri = 'data:text/javascript;charset=utf-8,export default "hi"'
+  const { default: hi } = await import({ toString: () => dataUri } as string)
+  expect(hi).toBe('hi')
+})
+
 test('dynamic import has Module symbol', async () => {
   const stringTimeoutMod = await import('./../src/timeout')
 

Original file line number	Diff line number	Diff line change
`@@ -267,7 +267,7 @@ export class ViteNodeRunner {`
`267`	`267`	`const mod = this.moduleCache.getByModuleId(moduleId)`
`268`	`268`
`269`	`269`	`const request = async (dep: string) => {`
`270`		`- const [id, depFsPath] = await this.resolveUrl(dep, fsPath)`
	`270`	+ const [id, depFsPath] = await this.resolveUrl(`${dep}`, fsPath)
`271`	`271`	`return this.dependencyRequest(id, depFsPath, callstack)`
`272`	`272`	`}`
`273`	`273`