fix(plugin-vue): don't inline template when __VUE_PROD_DEVTOOLS__#81
Merged
sxzz merged 2 commits intovitejs:mainfrom May 30, 2024
Merged
fix(plugin-vue): don't inline template when __VUE_PROD_DEVTOOLS__#81sxzz merged 2 commits intovitejs:mainfrom
__VUE_PROD_DEVTOOLS__#81sxzz merged 2 commits intovitejs:mainfrom
Conversation
|
Is there any plan to merge this fix? |
|
can we get a comment for this issues anniversary? hope 2 months is enough ;) |
sxzz
approved these changes
May 30, 2024
__VUE_PROD_DEVTOOLS__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure that the
setupsection is available in Vuejs Devtools when building with__VUE_PROD_DEVTOOLS__: true.Additional context
Original fix. Possible regression since then? vitejs/vite#4984
Another report with example reproduction: https://github.com/vuejs/devtools/issues/1940
Not sure if
defineExposeis supposed to play a role here.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).