feat: add support for non-dev jsx runtime#224
Merged
ArnaudBarre merged 1 commit intovitejs:mainfrom Sep 24, 2023
Merged
Conversation
0ddc6dd to
ce86503
Compare
Member
|
Is there any reason why ReScript is not generating code with jsxDev? This could have some benefits like adding information the for react devtools and making it work with https://github.com/ArnaudBarre/vite-plugin-react-click-to-component |
Contributor
Author
|
Hi @ArnaudBarre, I have no idea. I've done some searching but there's no insightful result. For what it's worth, it appears that it was implemented this way initially. As far as I'm concerned, it is likely a challenge and substantial effort to make jsxDev works seamlessly in the compiler. |
Member
|
Thanks for the great PR. I will merge this as there is also other cases where this can show up vitejs/vite-plugin-react-pages#132 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I stumble across an issue where the Fast Refresh feature doesn't work with a Vite plugin I'm maintaining. After examination, I identified the root cause: The generated code with
.jsextension usesreact/jsx-runtimefor JSX transformation instead ofreact/jsx-dev-runtime, because of this, the generated code is no longer eligible for applying Fest Refresh, which results in a full page reloaded.Here is a JS file generated by the compiler, for example (click to expand)
Filename:
Res.bs.jsIn order to fix it, this PR adds an extra check for such case so that the Fast Refresh works as expected.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).