Skip to content

fix: output correct error for empty import specifier#16055

Merged
bluwy merged 1 commit intovitejs:mainfrom
sapphi-red:fix/output-correct-error-for-empty-import-specifier
Feb 29, 2024
Merged

fix: output correct error for empty import specifier#16055
bluwy merged 1 commit intovitejs:mainfrom
sapphi-red:fix/output-correct-error-for-empty-import-specifier

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

Description

Reported at #8042 (reply in thread)
With this PR, the error will be:

[plugin:vite:import-analysis] Failed to resolve import "" from "index.html?html-proxy&index=0.js". Does the file exist?

I tested this by adding import '' in playground/resolve/index.html.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-edge-case Bug, but has workaround or limited in scope (priority) label Feb 29, 2024
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy bluwy merged commit a9112eb into vitejs:main Feb 29, 2024
@sapphi-red sapphi-red deleted the fix/output-correct-error-for-empty-import-specifier branch February 29, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2-edge-case Bug, but has workaround or limited in scope (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants