perf(hmr): skip traversed modules when checking circular imports (#15034)

skovhus · web-flow · commit 41e437fd6ff5 · 2023-11-21T11:34:51.000+08:00
diff --git a/packages/vite/src/node/server/hmr.ts b/packages/vite/src/node/server/hmr.ts
@@ -361,11 +361,13 @@ function propagateUpdate(
  * @param nodeChain The chain of nodes/imports that lead to the node.
  *   (The last node in the chain imports the `node` parameter)
  * @param currentChain The current chain tracked from the `node` parameter
+ * @param traversedModules The set of modules that have traversed
  */
 function isNodeWithinCircularImports(
   node: ModuleNode,
   nodeChain: ModuleNode[],
   currentChain: ModuleNode[] = [node],
+  traversedModules = new Set<ModuleNode>(),
 ): HasDeadEnd {
   // To help visualize how each parameters work, imagine this import graph:
   //
@@ -383,6 +385,11 @@ function isNodeWithinCircularImports(
   // It works by checking if any `node` importers are within `nodeChain`, which
   // means there's an import loop with a HMR-accepted module in it.
 
+  if (traversedModules.has(node)) {
+    return false
+  }
+  traversedModules.add(node)
+
   for (const importer of node.importers) {
     // Node may import itself which is safe
     if (importer === node) continue
@@ -416,6 +423,7 @@ function isNodeWithinCircularImports(
         importer,
         nodeChain,
         currentChain.concat(importer),
+        traversedModules,
       )
       if (result) return result
     }
