Skip to content

Commit 078c835

Browse files
authored
Merge pull request #558 from visionmedia/hotfix
Superagent downgrading
2 parents 0cfc198 + 8119278 commit 078c835

3 files changed

Lines changed: 100 additions & 55 deletions

File tree

package-lock.json

Lines changed: 81 additions & 53 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
},
3434
"dependencies": {
3535
"methods": "^1.1.2",
36-
"superagent": "^4.1.0"
36+
"superagent": "^3.8.3"
3737
},
3838
"devDependencies": {
3939
"body-parser": "^1.18.3",

test/supertest.js

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ const bodyParser = require('body-parser');
88
const cookieParser = require('cookie-parser');
99
const nock = require('nock');
1010

11+
process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
12+
1113
describe('request(url)', function () {
1214
it('should be supported', function (done) {
1315
const app = express();
@@ -114,7 +116,6 @@ describe('request(app)', function () {
114116

115117
request(server)
116118
.get('/')
117-
.trustLocalhost()
118119
.end(function (err, res) {
119120
if (err) return done(err);
120121
res.status.should.equal(200);
@@ -1196,4 +1197,20 @@ describe('request.get(url).query(vals) works as expected', function () {
11961197

11971198
nock.restore();
11981199
});
1200+
1201+
it('should assert using promises', function (done) {
1202+
const app = express();
1203+
1204+
app.get('/', function (req, res) {
1205+
res.status(400).send({ promise: true });
1206+
});
1207+
1208+
request(app)
1209+
.get('/')
1210+
.expect(400)
1211+
.then((res) => {
1212+
res.body.promise.should.be.equal(true);
1213+
done();
1214+
});
1215+
});
11991216
});

0 commit comments

Comments
 (0)