Upgrade humbug/box#8770
Merged
weirdan merged 5 commits intovimeo:masterfrom Nov 26, 2022
Merged
Conversation
Obtaining package version data from within a scoped PHAR file is a complicated topic, and it's been alternatively broken and fixed multiple times. This change moves version data access to a single class, so that we can fix it there should we need to. The rest of the code can just rely on PSALM_VERSION constant (which will be made unscoped in a further commit) or call `VersionUtils` methods.
It updates humbug/scoper as well, so some changes to scoper configuration are required. `PSALM_VERSION` and `PHP_PARSER_VERSION` constants are made unscoped to prevent various issues.
Compatibility between `ocramius/package-versions`, `composer/package-versions-deprecated`, `composer-runtime-api` and `humbug/box` (with `humbug/scoper` further complicating things)has been always a problematic area. So instead of trying to keep up with all the changes in all of those packages, we will now bake the version data (for the packages we need) into the PHAR file itself. Fixes vimeo#7606 Fixes vimeo#5399
This is an attempt to fix CirleCI issue in this build: https://app.circleci.com/pipelines/github/weirdan/psalm/666/workflows/33476cb1-d753-4e2d-b067-a5c92808d725/jobs/2457
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
humbug/boxand fixes issues with the version Psalm reports when it's built as PHAR.Fixes #7606
Fixes #5399
Fixes #7314