Fix union assertions#8324
Merged
orklah merged 13 commits intovimeo:masterfrom Jul 28, 2022
Merged
Conversation
Collaborator
Author
|
The shepherd issue seems to be present upstream: https://psalm.dev/r/e0bee4534f |
|
I found these snippets: https://psalm.dev/r/e0bee4534f<?php
/**
* Asserts that two variables are the same.
*
* @param object $actual
* @psalm-assert-if-true (a|b|c) $actual
*/
function assertSame($actual) : void {}
class a {}
class b {}
class c {}
/** @var object */
$actual = new c;
if (assertSame($actual)) {
/** @psalm-trace $actual */;
} |
orklah
reviewed
Jul 27, 2022
Collaborator
Author
|
Mm actually even with the additional int range handling in intersections we're still missing intersection logic for keyed arrays, I feel like I'm duplicating code already present in the assertion reconciler, once I fix the last unit case I'd still prefer to get this merged, but eventually we should be using the same code used in the assertion reconciler to perform intersections, differences&so on... |
Collaborator
Author
|
All done! |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8322, #8319 and a few other bugs introduced by #8077, by explicitly running the intersection logic only on IsIdentical assertions (due to the semantics of Type::intersectUnionTypes wasn't sure if we should run it on IsType assertions), and removing the custom intersection/equality logic which broke other stuff in the code.