Allow value-of to work with backed enums (fixes #7874).#8283
Allow value-of to work with backed enums (fixes #7874).#8283orklah merged 3 commits intovimeo:masterfrom
value-of to work with backed enums (fixes #7874).#8283Conversation
| // TODO turn this into an InvalidDocblock with a better error message. This is difficult because it | ||
| // has to happen after scanning has finished, otherwise the class might not have been scanned yet. |
There was a problem hiding this comment.
I'd like to get this to work, but unless there's a single point of analysis for docblocks after scanning has finished I'm not sure how, so I figure it can wait.
|
@orklah Do you think we should proactively change |
It might be better yeah, in order to let people understand those two are similar |
|
@orklah Ready for review, the bc error is expected and fine. |
|
Thanks! |
|
Hi @orklah @AndrolGenhald , |
|
4.27 should contain the fix. Do you have an example snippet? |
|
It's the same as above with the same error message. |
|
Actually this was targeted to the master branch, so the first version it's in is 5.0. @orklah maybe we should release another beta soon? |
|
oh sorry, didn't check the target indeed. We can release a beta if we want. I was hoping a final release in september after the immutable refactor but we may have to wait a bit more |
No description provided.