Feature: allow non-union assertion types#8077
Merged
orklah merged 18 commits intovimeo:masterfrom Jun 27, 2022
Merged
Conversation
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
fixes vimeo#5657 Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Collaborator
|
Could you take a look at the CI failures? |
Contributor
Author
|
Sure! Just need some time - gonna change this to draft for now. |
This will avoid issues with invalid intersection assertions. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
…ingle Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
…ar_id` Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
…tion Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
…eralInt` and `TLiteralString` Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
…pe, do not consider the new type as a replacement Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Collaborator
|
Seems interesting :) remove draft mode when it's ready ;) |
Contributor
Author
|
I am still working on it as there are some cases I'd like to work. Sadly, I have to manipulate the union in some special case and thus have to rework the current logic a bit. 😅 |
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Contributor
Author
|
Okay, I guess I have everything. |
…ored within a union Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
orklah
reviewed
Jun 13, 2022
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Collaborator
|
LGTM, tell me if it's ready from your side :) |
Contributor
Author
|
Its ready from my PoV 👌🏻 |
Collaborator
|
Thanks! |
This was referenced Jul 26, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #5657, I was wondering why
oneOfdoes not work as expected.That was due to the fact that psalm is simply not able to apply assertions for non-single union types.
This PR changes this and thus is declared as
featureeven tho the originating issue was flagged as a bug.