Skip to content

skip a test because we removed the feature for now#7642

Merged
orklah merged 1 commit intovimeo:masterfrom
orklah:brokenci2
Feb 11, 2022
Merged

skip a test because we removed the feature for now#7642
orklah merged 1 commit intovimeo:masterfrom
orklah:brokenci2

Conversation

@orklah
Copy link
Copy Markdown
Collaborator

@orklah orklah commented Feb 11, 2022

Not sure why this test doesn't explode on 4.x but we removed this feature for now due to shenanigans with stubs from plugins and this makes master branch fail

@weirdan
Copy link
Copy Markdown
Collaborator

weirdan commented Feb 11, 2022

why this test doesn't explode on 4.x

Because it's absent from that branch 🤷‍♂️

@weirdan weirdan added the release:internal The PR will be included in 'Internal changes' section of the release notes label Feb 11, 2022
@orklah orklah merged commit 29b856e into vimeo:master Feb 11, 2022
@AndrolGenhald
Copy link
Copy Markdown
Collaborator

I did a bit of work to allow mixed in stubs for PHP 7.4 on #7641, this test is still failing there though, I didn't look into it much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:internal The PR will be included in 'Internal changes' section of the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants