Ensure that all entries in test arrays have explicit keys#7386
Merged
Ensure that all entries in test arrays have explicit keys#7386
Conversation
orklah
reviewed
Jan 13, 2022
| [ | ||
| 'assertions' => [], | ||
| 'ignored_issues' => [ | ||
| 'InvalidDocblock' => Config::REPORT_INFO, |
Collaborator
There was a problem hiding this comment.
What does having a report option does here?
Collaborator
Author
There was a problem hiding this comment.
From what I recall it was an edge-case where this slight suppression was necessary to trigger a bug
orklah
reviewed
Jan 13, 2022
| 'error_levels' => [], | ||
| 'strict_mode' => true, | ||
| ], | ||
| 'concatenationWithNumberInStrictMode' => [ |
Collaborator
Author
There was a problem hiding this comment.
No, it was moved up into a custom section to remove the strict_mode argument from the trait signature
orklah
approved these changes
Jan 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR serves two purposes:
Obviously the second point doesn't benefit Psalm in any way, and if you feel the code change is an annoyance feel free to disregard this.