Skip to content

fix: _JSXStyle import is not found#724

Merged
huozhi merged 4 commits intovercel:masterfrom
huozhi:fix/jsxstyle-imports
Aug 2, 2021
Merged

fix: _JSXStyle import is not found#724
huozhi merged 4 commits intovercel:masterfrom
huozhi:fix/jsxstyle-imports

Conversation

@huozhi
Copy link
Copy Markdown
Contributor

@huozhi huozhi commented Jul 31, 2021

Chnages

Carry on work of #716 , generate import id in program scope

Related

Fixes #695
Fixes #696
Fixes #711

@huozhi huozhi requested a review from giuseppeg as a code owner July 31, 2021 10:34
@huozhi huozhi force-pushed the fix/jsxstyle-imports branch 2 times, most recently from 56a1bbb to 626d2b4 Compare July 31, 2021 10:38
Comment thread src/_utils.js Outdated
Comment thread test/babel6/snapshots/external.js.md Outdated
@huozhi huozhi requested a review from giuseppeg July 31, 2021 13:43
@huozhi huozhi force-pushed the fix/jsxstyle-imports branch from 94c96bc to 14fe5e0 Compare August 1, 2021 06:56
@masx200
Copy link
Copy Markdown

masx200 commented Aug 1, 2021

#711 (comment)

Why does this solve the problem?

@huozhi huozhi force-pushed the fix/jsxstyle-imports branch 2 times, most recently from 0d57f9e to 3a07c1f Compare August 1, 2021 07:03
create imports on program enter
@huozhi huozhi force-pushed the fix/jsxstyle-imports branch from 3a07c1f to 642fee2 Compare August 1, 2021 07:10
Comment thread src/_utils.js Outdated
@huozhi huozhi marked this pull request as draft August 1, 2021 08:24
@huozhi huozhi force-pushed the fix/jsxstyle-imports branch from bd32e13 to 0a517ed Compare August 1, 2021 10:08
Comment thread test/babel6/snapshots/index.js.md Outdated
Comment thread src/babel.js
Comment thread src/babel-external.js
Comment thread src/babel.js
Comment thread src/babel.js
Comment thread src/_utils.js
@huozhi huozhi marked this pull request as ready for review August 2, 2021 08:23
Copy link
Copy Markdown
Collaborator

@giuseppeg giuseppeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution and for your immense patience Jiachi!

@huozhi huozhi merged commit 2798620 into vercel:master Aug 2, 2021
@huozhi huozhi deleted the fix/jsxstyle-imports branch August 2, 2021 18:49
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 2, 2021

🎉 This PR is included in version 3.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

3 participants