Skip to content

Updates cms-sanity example to use Sanity v3 (#45662#45662

Merged
timneutkens merged 13 commits intovercel:canaryfrom
sanity-io:sanity-v3
Feb 27, 2023
Merged

Updates cms-sanity example to use Sanity v3 (#45662#45662
timneutkens merged 13 commits intovercel:canaryfrom
sanity-io:sanity-v3

Conversation

@snorrees
Copy link
Copy Markdown
Contributor

@snorrees snorrees commented Feb 7, 2023 •
edited by balazsorban44
Loading

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Fixes issues reported, for instance here: vercel/community#1449
(The example does not deploy atm and uses an old version of Sanity).

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • e2e tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see [contributing.md]
  • Updates the Sanity studio to use the latest v3 version. This required changing some files, as per migrating to Studio v3 docs.
  • Updated the README to reflect the changed procedure.
  • Update the next app to use the latest version of next-sanity. Changed related code as a result.

Testing

Tested using this deploy url (uses the branch from the forke repo):
https://vercel.com/new/clone?repository-url=https%3A%2F%2Fgithub.com%2Fsanity-io%2Fnext.js%2Ftree%2Fsanity-v3%2Fexamples%2Fcms-sanity&repository-name=cms-sanity&project-name=cms-sanity&demo-title=Blog+using+Next.js+%26+Sanity&demo-description=On-demand+ISR%2C+sub-second+as-you-type+previews&demo-url=https%3A%2F%2Fnext-blog-sanity.vercel.app%2F&demo-image=https%3A%2F%2Fuser-images.githubusercontent.com%2F110497645%2F182727236-75c02b1b-faed-4ae2-99ce-baa089f7f363.png&integration-ids=oac_hb2LITYajhRQ0i4QznmKH7gx

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

fixes #46450

@ijjk ijjk added the examples Issue was opened via the examples template. label Feb 7, 2023
snorrees
snorrees commented Feb 7, 2023
View reviewed changes
Comment thread examples/cms-sanity/README.md
jankaifer
jankaifer previously approved these changes Feb 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jankaifer jankaifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

leerob
leerob reviewed Feb 7, 2023
View reviewed changes
Comment thread examples/cms-sanity/components/cover-image.js Outdated
@jankaifer jankaifer self-requested a review February 7, 2023 15:56
@snorrees snorrees requested review from leerob and removed request for jankaifer February 8, 2023 09:06
@snorrees snorrees requested review from jankaifer and leerob and removed request for jankaifer and leerob February 8, 2023 09:07
leerob
leerob reviewed Feb 22, 2023
View reviewed changes
Comment thread examples/cms-sanity/lib/sanity.js Outdated
leerob
leerob previously approved these changes Feb 22, 2023
View reviewed changes
auto-merge was automatically disabled February 22, 2023 13:45

Head branch was pushed to by a user without write access

@snorrees snorrees dismissed stale reviews from leerob and jankaifer via 5cc908c February 22, 2023 13:45
@snorrees snorrees requested review from jankaifer and leerob and removed request for jankaifer and leerob February 22, 2023 16:49
leerob
leerob previously approved these changes Feb 23, 2023
View reviewed changes
@nashyvan
Copy link
Copy Markdown

nashyvan commented Feb 26, 2023

please merge this update, it fixes many issues

@nashyvan nashyvan mentioned this pull request Feb 26, 2023
Closed
1 task
@leerob
Copy link
Copy Markdown
Contributor

leerob commented Feb 26, 2023

Looks like there's a merge conflict 🙏

@snorrees
Merge remote-tracking branch 'vercel/canary' into sanity-v3
cfe0a9a 
# Conflicts:
#	examples/cms-sanity/pages/index.js
#	examples/cms-sanity/pages/posts/[slug].js
@snorrees
fix(cms-sanity): merge conflict
10f3ba9
@snorrees snorrees requested review from jankaifer and leerob and removed request for jankaifer February 27, 2023 10:34
@balazsorban44 balazsorban44 enabled auto-merge (squash) February 27, 2023 10:52
balazsorban44
balazsorban44 approved these changes Feb 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timneutkens timneutkens disabled auto-merge February 27, 2023 10:58
@timneutkens timneutkens changed the title Updates cms-sanity example to use Sanity v3 Updates cms-sanity example to use Sanity v3 (#45662 Feb 27, 2023
@timneutkens timneutkens merged commit 9d30f43 into vercel:canary Feb 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@steven-tey steven-tey Awaiting requested review from steven-tey

@leerob leerob Awaiting requested review from leerob

2 more reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@jankaifer jankaifer jankaifer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

examples Issue was opened via the examples template.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SyntaxError in examples cms-sanity

7 participants

@snorrees @nashyvan @leerob @jankaifer @balazsorban44 @timneutkens @ijjk