support for parsing date string with only time #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
+ Coverage 64.97% 68.30% +3.32%
==========================================
Files 3 6 +3
Lines 454 795 +341
Branches 93 188 +95
==========================================
+ Hits 295 543 +248
- Misses 111 130 +19
- Partials 48 122 +74
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
I'd have to look into this, but I wouldn't mind merging this as a temporary solution indeed. I'll have to continue my work on the new parser. Looks useful to have in the meantime! |
Contributor
Author
|
thanks 😄, i think i fixed the clippy and fmt errors is there anything else i should do? |
tertsdiepraam
approved these changes
Mar 3, 2024
Member
tertsdiepraam
left a comment
There was a problem hiding this comment.
Nope, looks pretty good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i was trying to fix the
date-sectest case in gnu test coverage in coreutils-date and i figured if i could make parse_datetime to take strings with only time and offset it would fix the issue and from the code I figured you guys are already working on a parser but as a temporary fix i wrote the following code to deal with the issue. Please do let me know if this not the way it was supposed to be implemented or any kind of change at all. Thank you