Skip to content

fix(parseURL): only normalize windows drive letters with file:// protocol#246

Merged
pi0 merged 1 commit intounjs:mainfrom
esyoil-GmbH:main
Jul 16, 2024
Merged

fix(parseURL): only normalize windows drive letters with file:// protocol#246
pi0 merged 1 commit intounjs:mainfrom
esyoil-GmbH:main

Conversation

@ea-agital
Copy link
Contributor

@ea-agital ea-agital commented Jul 12, 2024 •
edited
Loading

Issue: #247

URL paths which include a colon as the second character are falsely included in the fix for windows path URLs here resulting in the leading slash being removed.

@ea-agital ea-agital changed the title fix(parseURL): Edge case where leading slash is removed in normal URL paths fix(parseURL): Leading slash removed URLs including colon as second character in path Jul 12, 2024
@ea-agital ea-agital changed the title fix(parseURL): Leading slash removed URLs including colon as second character in path fix(parseURL): Leading slash removed from URLs including colon as second character in path Jul 12, 2024
@ea-agital ea-agital mentioned this pull request Jul 12, 2024
Closed
@pi0 pi0 changed the title fix(parseURL): Leading slash removed from URLs including colon as second character in path fix(parseURL): only normalize windows drive letters with file:// protocol Jul 16, 2024
pi0
pi0 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find thanks!

@pi0 pi0 requested a review from danielroe July 16, 2024 16:29
@codecov
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (d283cf5) to head (70d64cb).
Report is 49 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   95.27%   98.70%   +3.43%     
==========================================
  Files           7        7              
  Lines         867     1394     +527     
  Branches      187      237      +50     
==========================================
+ Hits          826     1376     +550     
+ Misses         41       18      -23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0 pi0 merged commit 229e83e into unjs:main Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ea-agital @pi0 @danielroe @kalekdev