fix(findExports): find declaration export with inline object or array#247
Merged
fix(findExports): find declaration export with inline object or array#247
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
- Coverage 88.04% 87.38% -0.66%
==========================================
Files 8 8
Lines 1062 1102 +40
Branches 188 200 +12
==========================================
+ Hits 935 963 +28
- Misses 127 139 +12 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
N/A
❓ Type of change
📚 Description
I find
findExportsgot the wrong result from export inline object or array, such as:export const foo = [ bar, baz, fgg ];or
export const foo = { bar, baz, fgg };It returns
[ "foo", "baz", "fgg" ]but it should be only
[ "foo" ]I haven't checked other functions like
findTypeExportsfindTypeExportsI have added some new tests and all tests passed on my machine locally.
📝 Checklist