Skip to content

perf(resolver): remove intermediate pcall util#230

Merged
pi0 merged 5 commits intomainfrom
perf/pcall
Feb 21, 2024
Merged

perf(resolver): remove intermediate pcall util#230
pi0 merged 5 commits intomainfrom
perf/pcall

Conversation

@pi0
Copy link
Copy Markdown
Member

@pi0 pi0 commented Feb 21, 2024

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Remove intermediate pcall util for async functions. it was mainly to reduce stacktrace size but seems really uncessary.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title perf/pcall perf(resolver): remove intermediate pcall util Feb 21, 2024
@pi0 pi0 merged commit 4469e7b into main Feb 21, 2024
@pi0 pi0 deleted the perf/pcall branch February 21, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant