Skip to content

fix(findExports): support multiple exports terminated with ;#72

Merged
pi0 merged 1 commit into
mainfrom
feat/export-regex-inline
Aug 22, 2022
Merged

fix(findExports): support multiple exports terminated with ;#72
pi0 merged 1 commit into
mainfrom
feat/export-regex-inline

Conversation

@antfu

@antfu antfu commented Aug 20, 2022

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Aug 20, 2022

Copy link
Copy Markdown

Codecov Report

Merging #72 (d0b5749) into main (d760c97) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   58.15%   58.19%   +0.04%     
==========================================
  Files          13       13              
  Lines        2196     2196              
  Branches      233      232       -1     
==========================================
+ Hits         1277     1278       +1     
  Misses        695      695              
+ Partials      224      223       -1     
Impacted Files Coverage Δ
src/analyze.ts 79.14% <100.00%> (+0.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title fix(exports): regex should terminate on ; fix(exports): support multiple exports terminated with ; Aug 22, 2022
@pi0 pi0 changed the title fix(exports): support multiple exports terminated with ; fix(findExports): support multiple exports terminated with ; Aug 22, 2022
@pi0

pi0 commented Aug 22, 2022

Copy link
Copy Markdown
Member

Thanks! Would you mind checking if we would also need this for imports?

@pi0 pi0 merged commit e7a8de3 into main Aug 22, 2022
@pi0 pi0 deleted the feat/export-regex-inline branch August 22, 2022 09:02
@antfu

antfu commented Aug 23, 2022

Copy link
Copy Markdown
Member Author

Yes imports have been covered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants