Skip to content

fix(resolve): always try to resolve url as dir too#67

Merged
pi0 merged 4 commits into
mainfrom
fix/resolve
Aug 11, 2022
Merged

fix(resolve): always try to resolve url as dir too#67
pi0 merged 4 commits into
mainfrom
fix/resolve

Conversation

@danielroe

@danielroe danielroe commented Aug 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

We are sometimes wrongly detecting directories as files. This PR updates behaviour not to distinguish between them, but assume either might be true.

@danielroe danielroe added the bug Something isn't working label Aug 11, 2022
@danielroe danielroe requested a review from pi0 August 11, 2022 09:39
@danielroe danielroe self-assigned this Aug 11, 2022
@codecov

codecov Bot commented Aug 11, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #67 (1c264ea) into main (4752796) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 1c264ea differs from pull request most recent head 25e618e. Consider uploading reports for the commit 25e618e to get more accurate results

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   58.20%   58.17%   -0.04%     
==========================================
  Files          13       13              
  Lines        2199     2195       -4     
  Branches      232      231       -1     
==========================================
- Hits         1280     1277       -3     
  Misses        696      696              
+ Partials      223      222       -1
Impacted Files Coverage Δ
src/resolve.ts 61.60% <100.00%> (-0.42%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danielroe danielroe changed the title fix: resolve child, not sibling directory fix: resolve siblings and children (in case url is a file/directory) Aug 11, 2022
@pi0 pi0 changed the title fix: resolve siblings and children (in case url is a file/directory) fix(resolve): always try to resolve as dir as fallback Aug 11, 2022
pi0
pi0 reviewed Aug 11, 2022
View reviewed changes
Comment thread src/resolve.ts
@pi0 pi0 changed the title fix(resolve): always try to resolve as dir as fallback fix(resolve): always try to resolve as dir too Aug 11, 2022
@pi0 pi0 changed the title fix(resolve): always try to resolve as dir too fix(resolve): always try to resolve url as dir too Aug 11, 2022
@pi0 pi0 merged commit dd14c01 into main Aug 11, 2022
@pi0 pi0 deleted the fix/resolve branch August 11, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe @pi0