fix(findExports): get exports with trailing comma#61
Conversation
Member
|
Can you add some tests to the case you are solving? Thanks |
Author
|
Test cases have been added |
antfu
approved these changes
Jul 27, 2022
pi0
approved these changes
Aug 3, 2022
Member
|
Thanks for PR @westhide <3 And sorry it merged late. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct #59
Adjust EXPORT_NAMED_RE regex not to match the
trailing comma & blankin export name, so no need to filter !!name after split exports