fix(resolver): strictly check input

pi0 · pi0 · commit 778bd735e298 · 2024-02-21T14:51:03.000+01:00
diff --git a/src/resolve.ts b/src/resolve.ts
@@ -37,7 +37,15 @@ function _tryModuleResolve(
   }
 }
 
-function _resolve(id: string, options: ResolveOptions = {}): string {
+function _resolve(id: string | URL, options: ResolveOptions = {}): string {
+  if (typeof id !== "string") {
+    if (id instanceof URL) {
+      id = fileURLToPath(id);
+    } else {
+      throw new TypeError("input must be a `string` or `URL`");
+    }
+  }
+
   // Skip if already has a protocol
   if (/(node|data|http|https):/.test(id)) {
     return id;
@@ -49,7 +57,7 @@ function _resolve(id: string, options: ResolveOptions = {}): string {
   }
 
   // Enable fast path for file urls
-  if (id.startsWith("file:")) {
+  if (id.startsWith("file://")) {
     id = fileURLToPath(id);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,15 @@ function _tryModuleResolve(`
`37`	`37`	`}`
`38`	`38`	`}`
`39`	`39`
`40`		`-function _resolve(id: string, options: ResolveOptions = {}): string {`
	`40`	`+function _resolve(id: string \| URL, options: ResolveOptions = {}): string {`
	`41`	`+ if (typeof id !== "string") {`
	`42`	`+ if (id instanceof URL) {`
	`43`	`+ id = fileURLToPath(id);`
	`44`	`+ } else {`
	`45`	+ throw new TypeError("input must be a `string` or `URL`");
	`46`	`+ }`
	`47`	`+ }`
	`48`	`+`
`41`	`49`	`// Skip if already has a protocol`
`42`	`50`	`if (/(node\|data\|http\|https):/.test(id)) {`
`43`	`51`	`return id;`
`@@ -49,7 +57,7 @@ function _resolve(id: string, options: ResolveOptions = {}): string {`
`49`	`57`	`}`
`50`	`58`
`51`	`59`	`// Enable fast path for file urls`
`52`		`- if (id.startsWith("file:")) {`
	`60`	`+ if (id.startsWith("file://")) {`
`53`	`61`	`id = fileURLToPath(id);`
`54`	`62`	`}`
`55`	`63`