fix(eslint-plugin): [prefer-optional-chain] handle binary expressions in negated or#5992
Conversation
|
Thanks for the PR, @omril1! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…ryExpression-in-negated-or
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Looks great in general, thanks for sending this in so quickly! Just requesting changes for a little code simplification please. 🎉
…ryExpression-in-negated-or
|
@omril1 Thanks for the quick fix! @JoshuaKGoldberg Do you have an estimate of when this fix will be released? My project is also affected by this issue, thus looking forward to the next release. |
|
@bradzacher Thanks! I must have been blind! 🙈 |
PR Checklist
Overview
I'm not sure why the default switch case is to throw instead of ignoring the code 😢
The issue was not yet triaged but I opened a PR just in case