Skip to content

fix(eslint-plugin): [member-delimiter-style] autofixer result is not as expected with option delimiter: 'none'#5023

Merged
JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfrom
holazz:fix/member-delimiter-style
May 20, 2022
Merged

fix(eslint-plugin): [member-delimiter-style] autofixer result is not as expected with option delimiter: 'none'#5023
JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfrom
holazz:fix/member-delimiter-style

Conversation

@holazz
Copy link
Copy Markdown
Contributor

@holazz holazz commented May 20, 2022 •
edited
Loading

autofixer result is not as expected with option delimiter: 'none'

PR Checklist

Overview

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 20, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8a5067b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 20, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 8a5067b
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62881bfd58908900087eaa52
😎 Deploy Preview https://deploy-preview-5023--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@typescript-eslint
Copy link
Copy Markdown
Contributor

typescript-eslint Bot commented May 20, 2022

Thanks for the PR, @holazz!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2022 •
edited
Loading

Codecov Report

Merging #5023 (b2b07c0) into main (7ee0bd0) will increase coverage by 2.46%.
The diff coverage is 100.00%.

❗ Current head b2b07c0 differs from pull request most recent head 8a5067b. Consider uploading reports for the commit 8a5067b to get more accurate results

@@            Coverage Diff             @@
##             main    #5023      +/-   ##
==========================================
+ Coverage   91.32%   93.79%   +2.46%     
==========================================
  Files         132      286     +154     
  Lines        1487     9795    +8308     
  Branches      224     2930    +2706     
==========================================
+ Hits         1358     9187    +7829     
- Misses         65      328     +263     
- Partials       64      280     +216
Flag Coverage Δ
unittest 93.79% <100.00%> (+2.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../eslint-plugin/src/rules/member-delimiter-style.ts 94.11% <100.00%> (ø)
...eslint-plugin/src/rules/no-parameter-properties.ts 94.11% <0.00%> (ø)
...es/eslint-plugin/src/util/getOperatorPrecedence.ts 42.85% <0.00%> (ø)
...kages/eslint-plugin/src/rules/func-call-spacing.ts 96.87% <0.00%> (ø)
...kages/eslint-plugin/src/rules/no-base-to-string.ts 98.41% <0.00%> (ø)
...src/rules/naming-convention-utils/parse-options.ts 100.00% <0.00%> (ø)
...slint-plugin/src/rules/no-unnecessary-qualifier.ts 100.00% <0.00%> (ø)
packages/eslint-plugin/src/configs/recommended.ts 100.00% <0.00%> (ø)
...-plugin/src/rules/explicit-member-accessibility.ts 97.18% <0.00%> (ø)
...n/src/rules/no-non-null-asserted-optional-chain.ts 46.66% <0.00%> (ø)
... and 145 more

@bradzacher bradzacher added the bug Something isn't working label May 20, 2022
JoshuaKGoldberg
JoshuaKGoldberg reviewed May 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending the issue & PR, always appreciated! ❤️‍🔥

Marking as blocked pending more info in #5022. As much as we love contributions, we recommend waiting till issues are marked as accepting PRs before sending in code to make sure we can accept the contribution.

@JoshuaKGoldberg JoshuaKGoldberg added the blocked by another issue Issues which are not ready because another issue needs to be resolved first label May 20, 2022
JoshuaKGoldberg
JoshuaKGoldberg approved these changes May 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks! This fix looks perfect. 💯

@JoshuaKGoldberg JoshuaKGoldberg removed the blocked by another issue Issues which are not ready because another issue needs to be resolved first label May 20, 2022
@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) May 20, 2022 22:53
@JoshuaKGoldberg JoshuaKGoldberg merged commit 9e97a11 into typescript-eslint:main May 20, 2022
@holazz holazz deleted the fix/member-delimiter-style branch May 21, 2022 00:33
@holazz holazz mentioned this pull request May 21, 2022
Closed
4 tasks
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

+1 more reviewer

@armano2 armano2 armano2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: [member-delimiter-style] autofixer result is not as expected with option delimiter: 'none'

4 participants

@holazz @armano2 @JoshuaKGoldberg @bradzacher