Update type for Matchers to match @types/jest#150
Merged
gnapse merged 2 commits intotesting-library:masterfrom Oct 31, 2019
bopfer:pr/update-matchers-type
Merged
Update type for Matchers to match @types/jest#150gnapse merged 2 commits intotesting-library:masterfrom bopfer:pr/update-matchers-type
gnapse merged 2 commits intotesting-library:masterfrom
bopfer:pr/update-matchers-type
Conversation
wKovacs64
approved these changes
Oct 27, 2019
jgoz
approved these changes
Oct 28, 2019
Collaborator
jgoz
left a comment
There was a problem hiding this comment.
👍 thank you
I guess this might lead to some confusion if people upgrade jest-dom without also upgrading @types/jest, but that will be an easy fix.
Collaborator
|
@gnapse Any thoughts on this? Seems like it's blocking a lot of people. |
Member
|
I'll be merging it now as soon as the CI build passes. One question: does this close #152? That issue description is not clear enough, but I see that it was attempted to be fixed in #153 and then that one got closed with a mention that it was a duplicate of this. So I just want to make sure we can close #152 after we merge this? |
Member
|
🎉 This PR is included in version 4.2.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
@types/jestrecently had some updates to correct the type forMatchers. This update is a breaking change for any TypeScript project that uses expect.extend.See: DefinitelyTyped/DefinitelyTyped#39243
Why:
@testing-library/jest-domdefines theMatcherstype inextend-expect.d.ts.How:
The change was simply to update the type to match
@types/jest.Checklist: