feat(prefer-presence-queries): support react-native matcher toBeOnTheScreen#844
Merged
Belco90 merged 1 commit intotesting-library:mainfrom Nov 21, 2023
Merged
feat(prefer-presence-queries): support react-native matcher toBeOnTheScreen#844Belco90 merged 1 commit intotesting-library:mainfrom
toBeOnTheScreen#844Belco90 merged 1 commit intotesting-library:mainfrom
Conversation
Belco90
requested changes
Nov 17, 2023
Member
Belco90
left a comment
There was a problem hiding this comment.
Thanks for your contribution. Can you add some valid and invalid tests, please? Thanks.
…om react-native matcher `toBeOnTheScreen`s Signed-off-by: Davyd NRB <4661784+retyui@users.noreply.github.com>
Contributor
Author
ready |
testing-library/prefer-presence-queries rule to support custom react-native matcher toBeOnTheScreentoBeOnTheScreen
Belco90
approved these changes
Nov 21, 2023
|
🎉 This PR is included in version 6.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks
Changes
React Native Testing Library recommend to use this eslint plugin: https://callstack.github.io/react-native-testing-library/docs/eslint-plugin-testing-library
React Native Testing Library has custom matchers: https://callstack.github.io/react-native-testing-library/docs/jest-matchers#tobeonthescreen
this PR adding support for support for that matsher
toBeOnTheScreenContext
...