Skip to content

fix(await-async-event): pluralize to await-async-events#670

Merged
Belco90 merged 1 commit intoalphafrom
pr/fix-await-async-events-name
Oct 5, 2022
Merged

fix(await-async-event): pluralize to await-async-events#670
Belco90 merged 1 commit intoalphafrom
pr/fix-await-async-events-name

Conversation

@skovy
Copy link
Copy Markdown
Collaborator

@skovy skovy commented Oct 5, 2022

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list (npm run generate:rules-list)
  • If some rule meta info is changed, I've regenerated the plugin shared configs (npm run generate:configs)

Changes

  • I originally goofed on the naming of this rule when renaming, it should be plural.

Context

Fully resolves #626.

@skovy skovy added the v6 Next major v6 label Oct 5, 2022
Copy link
Copy Markdown
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the migration doc, right?

@skovy
Copy link
Copy Markdown
Collaborator Author

skovy commented Oct 5, 2022

@Belco90 I believe I did that in the other PR since they were both open at the same time, but I can double check 👍

Copy link
Copy Markdown
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right! The migration docs were fine already.

@Belco90 Belco90 merged commit 7238f76 into alpha Oct 5, 2022
@Belco90 Belco90 deleted the pr/fix-await-async-events-name branch October 5, 2022 21:43
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 5, 2022

🎉 This PR is included in version 6.0.0-alpha.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

3 participants