feat(no-debugging-utils): enable all methods#663
Merged
Belco90 merged 1 commit intotesting-library:alphafrom Oct 3, 2022
skovy:pr/no-debugging-utils-report-all
Merged
feat(no-debugging-utils): enable all methods#663Belco90 merged 1 commit intotesting-library:alphafrom skovy:pr/no-debugging-utils-report-all
Belco90 merged 1 commit intotesting-library:alphafrom
skovy:pr/no-debugging-utils-report-all
Conversation
skovy
commented
Oct 2, 2022
no-debugging-utils enable all methods
Belco90
requested changes
Oct 3, 2022
Member
Belco90
left a comment
There was a problem hiding this comment.
Can you remove the options for all the valid/invalid tests manually enabling to report certain debugging methods? They are enabled by default so we don't need to set them explicitly.
BREAKING CHANGE: enable all debug methods by default for no-debugging-utils
Collaborator
Author
|
Ah, yea! I think I removed all of the ones that weren't explicitly part of the test. Let me know if I missed any |
Belco90
approved these changes
Oct 3, 2022
|
🎉 This PR is included in version 6.0.0-alpha.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
MichaelDeBoey
pushed a commit
that referenced
this pull request
Oct 4, 2022
…default (#663) BREAKING CHANGE: `no-debugging-utils` now enables all debug methods in all configs by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: enable all debug methods by default for
no-debugging-utilsChecks
npm run generate:rules-list)npm run generate:configs)Changes
no-debugging-utilsruleContext
Resolves #621